Commit a1e7c799 authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: libsas: Simplify sas_ata_qc_issue() detection of NCQ commands 

To detect if a command is NCQ, there is no need to test all possible NCQ
command codes. Instead, use ata_is_ncq() to test the command protocol.

Link: https://lore.kernel.org/r/20220220031810.738362-24-damien.lemoal@opensource.wdc.com


Reviewed-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f792a362

drivers/scsi/libsas/sas_ata.c

+2 −7
Original line number Diff line number Diff line
@@ -179,14 +179,9 @@ static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) 
	task->task_proto = SAS_PROTOCOL_STP;

	task->task_done = sas_ata_task_done;



	if (qc->tf.command == ATA_CMD_FPDMA_WRITE ||

	    qc->tf.command == ATA_CMD_FPDMA_READ ||

	    qc->tf.command == ATA_CMD_FPDMA_RECV ||

	    qc->tf.command == ATA_CMD_FPDMA_SEND ||

	    qc->tf.command == ATA_CMD_NCQ_NON_DATA) {

		/* Need to zero out the tag libata assigned us */

	/* For NCQ commands, zero out the tag libata assigned us */

	if (ata_is_ncq(qc->tf.protocol))

		qc->tf.nsect = 0;

	}



	ata_tf_to_fis(&qc->tf, qc->dev->link->pmp, 1, (u8 *)&task->ata_task.fis);

	task->uldd_task = qc;