Commit a223ce19 authored by Dan Carpenter's avatar Dan Carpenter Committed by Dave Jiang
Browse files

cxl/hdm: Clean up a debug printk 



Smatch complains that %pa is for phys_addr_t types and "size" is a u64.

    drivers/cxl/core/hdm.c:521 cxl_dpa_alloc() error: '%pa' expects
    argument of type 'phys_addr_t*', argument 4 has type 'ullong*

Looking at this, to me it seems more useful to print the sizes as
decimal instead of hex.  Let's do that.

[dj: Adjusted based on latest code changes. ]

Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarFan Ni <fan.ni@samsung.com>
Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Link: https://patch.msgid.link/3d3d969d-651d-4e9d-a892-900876a60ab5@moroto.mountain


Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
parent 68d8b4f3

drivers/cxl/core/core.h

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr, 
struct dentry *cxl_debugfs_create_dir(const char *dir);

int cxl_dpa_set_part(struct cxl_endpoint_decoder *cxled,

		     enum cxl_partition_mode mode);

int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size);

int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, u64 size);

int cxl_dpa_free(struct cxl_endpoint_decoder *cxled);

resource_size_t cxl_dpa_size(struct cxl_endpoint_decoder *cxled);

resource_size_t cxl_dpa_resource_start(struct cxl_endpoint_decoder *cxled);

drivers/cxl/core/hdm.c

+4 −4
Original line number Diff line number Diff line
@@ -604,7 +604,7 @@ int cxl_dpa_set_part(struct cxl_endpoint_decoder *cxled, 
	return 0;

}



static int __cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)

static int __cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, u64 size)

{

	struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);

	struct cxl_dev_state *cxlds = cxlmd->cxlds;
@@ -667,15 +667,15 @@ static int __cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long lon 
		skip = res->start - skip_start;



	if (size > avail) {

		dev_dbg(dev, "%pa exceeds available %s capacity: %pa\n", &size,

			res->name, &avail);

		dev_dbg(dev, "%llu exceeds available %s capacity: %llu\n", size,

			res->name, (u64)avail);

		return -ENOSPC;

	}



	return __cxl_dpa_reserve(cxled, start, size, skip);

}



int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)

int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, u64 size)

{

	struct cxl_port *port = cxled_to_port(cxled);

	int rc;