Commit a23c14b0 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Jonathan Cameron
Browse files

iio: temperature: mlx90635: Fix ERR_PTR dereference in mlx90635_probe() 



When devm_regmap_init_i2c() fails, regmap_ee could be error pointer,
instead of checking for IS_ERR(regmap_ee), regmap is checked which looks
like a copy paste error.

Fixes: a1d1ba5e ("iio: temperature: mlx90635 MLX90635 IR Temperature sensor")
Reviewed-by: default avatarCrt <Mori&lt;cmo@melexis.com>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20240513203427.3208696-1-harshit.m.mogalapalli@oracle.com


Cc: <Stable@vger.kernel.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent bedb2ccb

drivers/iio/temperature/mlx90635.c

+3 −3
Original line number Diff line number Diff line
@@ -947,9 +947,9 @@ static int mlx90635_probe(struct i2c_client *client) 
				     "failed to allocate regmap\n");



	regmap_ee = devm_regmap_init_i2c(client, &mlx90635_regmap_ee);

	if (IS_ERR(regmap))

		return dev_err_probe(&client->dev, PTR_ERR(regmap),

				     "failed to allocate regmap\n");

	if (IS_ERR(regmap_ee))

		return dev_err_probe(&client->dev, PTR_ERR(regmap_ee),

				     "failed to allocate EEPROM regmap\n");



	mlx90635 = iio_priv(indio_dev);

	i2c_set_clientdata(client, indio_dev);