Commit a487c9e7 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: pcs: xpcs: get rid of xpcs_init_iface() 



xpcs_init_iface() no longer does anything with the interface mode, and
now merely does configuration related to the PMA ID. Move this back
into xpcs_create() as it doesn't warrant being a separate function
anymore.

Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://patch.msgid.link/E1svfML-005ZIF-84@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 92fb8986

drivers/net/pcs/pcs-xpcs.c

+4 −13
Original line number Diff line number Diff line
@@ -1483,16 +1483,6 @@ static int xpcs_init_id(struct dw_xpcs *xpcs) 
	return 0;

}



static int xpcs_init_iface(struct dw_xpcs *xpcs)

{

	if (xpcs->info.pma == WX_TXGBE_XPCS_PMA_10G_ID)

		xpcs->pcs.poll = false;

	else

		xpcs->need_reset = true;



	return 0;

}



static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev)

{

	struct dw_xpcs *xpcs;
@@ -1510,9 +1500,10 @@ static struct dw_xpcs *xpcs_create(struct mdio_device *mdiodev) 
	if (ret)

		goto out_clear_clks;



	ret = xpcs_init_iface(xpcs);

	if (ret)

		goto out_clear_clks;

	if (xpcs->info.pma == WX_TXGBE_XPCS_PMA_10G_ID)

		xpcs->pcs.poll = false;

	else

		xpcs->need_reset = true;



	return xpcs;