Commit a6a243b6 authored by Anand Moon's avatar Anand Moon Committed by Greg Kroah-Hartman
Browse files

usb: ohci-exynos: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions 



This macro has the advantage over SIMPLE_DEV_PM_OPS that we don't have to
care about when the functions are actually used.

Also make use of pm_ptr() to discard all PM related stuff if CONFIG_PM
isn't enabled.

Signed-off-by: default avatarAnand Moon <linux.amoon@gmail.com>
Link: https://lore.kernel.org/r/20240412142317.5191-5-linux.amoon@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3d284c95

drivers/usb/host/ohci-exynos.c

+3 −10
Original line number Diff line number Diff line
@@ -213,7 +213,6 @@ static void exynos_ohci_shutdown(struct platform_device *pdev) 
		hcd->driver->shutdown(hcd);

}



#ifdef CONFIG_PM

static int exynos_ohci_suspend(struct device *dev)

{

	struct usb_hcd *hcd = dev_get_drvdata(dev);
@@ -250,19 +249,13 @@ static int exynos_ohci_resume(struct device *dev) 


	return 0;

}

#else

#define exynos_ohci_suspend	NULL

#define exynos_ohci_resume	NULL

#endif



static const struct ohci_driver_overrides exynos_overrides __initconst = {

	.extra_priv_size =	sizeof(struct exynos_ohci_hcd),

};



static const struct dev_pm_ops exynos_ohci_pm_ops = {

	.suspend	= exynos_ohci_suspend,

	.resume		= exynos_ohci_resume,

};

static DEFINE_SIMPLE_DEV_PM_OPS(exynos_ohci_pm_ops,

				exynos_ohci_suspend, exynos_ohci_resume);



#ifdef CONFIG_OF

static const struct of_device_id exynos_ohci_match[] = {
@@ -278,7 +271,7 @@ static struct platform_driver exynos_ohci_driver = { 
	.shutdown	= exynos_ohci_shutdown,

	.driver = {

		.name	= "exynos-ohci",

		.pm	= &exynos_ohci_pm_ops,

		.pm	= pm_ptr(&exynos_ohci_pm_ops),

		.of_match_table	= of_match_ptr(exynos_ohci_match),

	}

};