Unverified Commit a7e8f3ef authored by Johan Hovold's avatar Johan Hovold Committed by Mark Brown
Browse files

spi: qup: fix error pointer deref after DMA setup failure 

The driver falls back to PIO mode if DMA setup fails during probe.

Make sure to the clear the DMA channel pointers on setup failure to
avoid dereferencing an error pointer (or attempting to release a channel
a second time) on later probe errors or driver unbind.

This issue was flagged by Sashiko when reviewing a devres allocation
conversion patch.

Fixes: 612762e8 ("spi: qup: Add DMA capabilities")
Link: https://sashiko.dev/#/patchset/20260505072909.618363-1-johan%40kernel.org?part=4


Cc: stable@vger.kernel.org	# 4.1
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260512074334.914735-1-johan@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 496ba79b

drivers/spi/spi-qup.c

+3 −0
Original line number Diff line number Diff line
@@ -996,8 +996,11 @@ static int spi_qup_init_dma(struct spi_controller *host, resource_size_t base) 


err:

	dma_release_channel(host->dma_tx);

	host->dma_tx = NULL;

err_tx:

	dma_release_channel(host->dma_rx);

	host->dma_rx = NULL;



	return ret;

}