Commit aece2094 authored by Aric Cyr's avatar Aric Cyr Committed by Alex Deucher
Browse files

drm/amd/display: Fix compiler warnings on high compiler warning levels 



[why]
Enabling higher compiler warning levels results in many issues that can
be trivially resolved as well as some potentially critical issues.

[how]
Fix all compiler warnings found with various compilers and higher
warning levels.  Primarily, potentially uninitialized variables and
unreachable code.

Reviewed-by: default avatarLeo Li <sunpeng.li@amd.com>
Acked-by: default avatarRoman Li <roman.li@amd.com>
Signed-off-by: default avatarAric Cyr <aric.cyr@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent cc520964

drivers/gpu/drm/amd/display/dc/bios/bios_parser2.c

+0 −2
Original line number Diff line number Diff line
@@ -1594,8 +1594,6 @@ static bool bios_parser_is_device_id_supported( 
		return (le16_to_cpu(bp->object_info_tbl.v1_5->supporteddevices) & mask) != 0;

		break;

	}



	return false;

}



static uint32_t bios_parser_get_ss_entry_number(

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c

+2 −1
Original line number Diff line number Diff line
@@ -642,7 +642,8 @@ static void rn_clk_mgr_helper_populate_bw_params(struct clk_bw_params *bw_params 


	j = -1;



	ASSERT(PP_SMU_NUM_FCLK_DPM_LEVELS <= MAX_NUM_DPM_LVL);

	static_assert(PP_SMU_NUM_FCLK_DPM_LEVELS <= MAX_NUM_DPM_LVL,

		"number of reported FCLK DPM levels exceed maximum");



	/* Find lowest DPM, FCLK is filled in reverse order*/

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn301/vg_clk_mgr.c

+2 −1
Original line number Diff line number Diff line
@@ -566,7 +566,8 @@ static void vg_clk_mgr_helper_populate_bw_params( 


	j = -1;



	ASSERT(VG_NUM_FCLK_DPM_LEVELS <= MAX_NUM_DPM_LVL);

	static_assert(VG_NUM_FCLK_DPM_LEVELS <= MAX_NUM_DPM_LVL,

		"number of reported FCLK DPM levels exceeds maximum");



	/* Find lowest DPM, FCLK is filled in reverse order*/

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn31/dcn31_clk_mgr.c

+2 −1
Original line number Diff line number Diff line
@@ -562,7 +562,8 @@ static void dcn31_clk_mgr_helper_populate_bw_params(struct clk_mgr_internal *clk 


	j = -1;



	ASSERT(NUM_DF_PSTATE_LEVELS <= MAX_NUM_DPM_LVL);

	static_assert(NUM_DF_PSTATE_LEVELS <= MAX_NUM_DPM_LVL,

		"number of reported pstate levels exceeds maximum");



	/* Find lowest DPM, FCLK is filled in reverse order*/

drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c

+2 −1
Original line number Diff line number Diff line
@@ -480,7 +480,8 @@ static void dcn316_clk_mgr_helper_populate_bw_params( 


	j = -1;



	ASSERT(NUM_DF_PSTATE_LEVELS <= MAX_NUM_DPM_LVL);

	static_assert(NUM_DF_PSTATE_LEVELS <= MAX_NUM_DPM_LVL,

		"number of reported pstate levels exceeds maximum");



	/* Find lowest DPM, FCLK is filled in reverse order*/