Commit af2b428f authored by Jacob Keller's avatar Jacob Keller Committed by Paolo Abeni
Browse files

broadcom: fix supported flag check in periodic output function 



In bcm_ptp_perout_locked, the driver rejects requests which have
PTP_PEROUT_PHASE set. This appears to be an attempt to reject any
unsupported flags. Unfortunately, this only checks one flag, but does not
protect against PTP_PEROUT_ONE_SHOT, or any future flags which may be
added.

Fix the check to ensure that no flag other than the supported
PTP_PEROUT_DUTY_CYCLE is set.

Fixes: 7bfe91ef ("net: phy: Add support for 1PPS out and external timestamps")
Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250312-jk-net-fixes-supported-extts-flags-v2-4-ea930ba82459@intel.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c0b4ddd3

drivers/net/phy/bcm-phy-ptp.c

+2 −1
Original line number Diff line number Diff line
@@ -597,7 +597,8 @@ static int bcm_ptp_perout_locked(struct bcm_ptp_private *priv, 


	period = BCM_MAX_PERIOD_8NS;	/* write nonzero value */



	if (req->flags & PTP_PEROUT_PHASE)

	/* Reject unsupported flags */

	if (req->flags & ~PTP_PEROUT_DUTY_CYCLE)

		return -EOPNOTSUPP;



	if (req->flags & PTP_PEROUT_DUTY_CYCLE)