Unverified Commit b1211a25 authored by Christian Brauner's avatar Christian Brauner
Browse files

bdev: make bdev_{release, open_by_dev}() private to block layer 

Move both of them to the private block header. There's no caller in the
tree anymore that uses them directly.

Link: https://lore.kernel.org/r/20240123-vfs-bdev-file-v2-28-adbd023e19cc@kernel.org


Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent e97d06a4

block/bdev.c

+0 −2
Original line number Diff line number Diff line
@@ -916,7 +916,6 @@ struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder, 
	kfree(handle);

	return ERR_PTR(ret);

}

EXPORT_SYMBOL(bdev_open_by_dev);



/*

 * If BLK_OPEN_WRITE_IOCTL is set then this is a historical quirk
@@ -1042,7 +1041,6 @@ void bdev_release(struct bdev_handle *handle) 
	blkdev_put_no_open(bdev);

	kfree(handle);

}

EXPORT_SYMBOL(bdev_release);



/**

 * lookup_bdev() - Look up a struct block_device by name.

block/blk.h

+4 −0
Original line number Diff line number Diff line
@@ -516,4 +516,8 @@ static inline int req_ref_read(struct request *req) 
	return atomic_read(&req->ref);

}



void bdev_release(struct bdev_handle *handle);

struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,

		const struct blk_holder_ops *hops);



#endif /* BLK_INTERNAL_H */

include/linux/blkdev.h

+0 −3
Original line number Diff line number Diff line
@@ -1482,8 +1482,6 @@ struct bdev_handle { 
	blk_mode_t mode;

};



struct bdev_handle *bdev_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,

		const struct blk_holder_ops *hops);

struct file *bdev_file_open_by_dev(dev_t dev, blk_mode_t mode, void *holder,

		const struct blk_holder_ops *hops);

struct file *bdev_file_open_by_path(const char *path, blk_mode_t mode,
@@ -1491,7 +1489,6 @@ struct file *bdev_file_open_by_path(const char *path, blk_mode_t mode, 
int bd_prepare_to_claim(struct block_device *bdev, void *holder,

		const struct blk_holder_ops *hops);

void bd_abort_claiming(struct block_device *bdev, void *holder);

void bdev_release(struct bdev_handle *handle);



/* just for blk-cgroup, don't use elsewhere */

struct block_device *blkdev_get_no_open(dev_t dev);