Commit b19f69a9 authored by Hongbo Li's avatar Hongbo Li Committed by Jakub Kicinski
Browse files

net/ipv6: replace deprecated strcpy with strscpy 

The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy

 [1]

Signed-off-by: default avatarHongbo Li <lihongbo22@huawei.com>
Link: https://patch.msgid.link/20240828123224.3697672-3-lihongbo22@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 68016b99

net/ipv6/ndisc.c

+1 −1
Original line number Diff line number Diff line
@@ -1944,7 +1944,7 @@ static void ndisc_warn_deprecated_sysctl(const struct ctl_table *ctl, 
	static char warncomm[TASK_COMM_LEN];

	static int warned;

	if (strcmp(warncomm, current->comm) && warned < 5) {

		strcpy(warncomm, current->comm);

		strscpy(warncomm, current->comm);

		pr_warn("process `%s' is using deprecated sysctl (%s) net.ipv6.neigh.%s.%s - use net.ipv6.neigh.%s.%s_ms instead\n",

			warncomm, func,

			dev_name, ctl->procname,