Commit b2284768 authored by Jason Wang's avatar Jason Wang Committed by Jakub Kicinski
Browse files

virtio-net: zero unused hash fields 



When GSO tunnel is negotiated virtio_net_hdr_tnl_from_skb() tries to
initialize the tunnel metadata but forget to zero unused rxhash
fields. This may leak information to another side. Fixing this by
zeroing the unused hash fields.

Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Fixes: a2fb4bc4 ("net: implement virtio helpers to handle UDP GSO tunneling")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
Link: https://patch.msgid.link/20251022034421.70244-1-jasowang@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 399d1093

include/linux/virtio_net.h

+4 −0
Original line number Diff line number Diff line
@@ -401,6 +401,10 @@ virtio_net_hdr_tnl_from_skb(const struct sk_buff *skb, 
	if (!tnl_hdr_negotiated)

		return -EINVAL;



        vhdr->hash_hdr.hash_value = 0;

        vhdr->hash_hdr.hash_report = 0;

        vhdr->hash_hdr.padding = 0;



	/* Let the basic parsing deal with plain GSO features. */

	skb_shinfo(skb)->gso_type &= ~tnl_gso_type;

	ret = virtio_net_hdr_from_skb(skb, hdr, true, false, vlan_hlen);