Commit b2b6fa6f authored by Mario Limonciello's avatar Mario Limonciello Committed by Hans de Goede
Browse files

platform/x86/amd/pmf: Fix a suspend hang on Framework 13 



The buffer is cleared in the suspend handler but used in
the delayed work for amd_pmf_get_metrics().

Stop clearing it to fix the hang.

Reported-by: default avatarTrolli Schmittlauch <t.schmittlauch@orlives.de>
Closes: https://lore.kernel.org/regressions/ed2226ff-257b-4cfd-afd6-bf3be9785474@localhost/
Closes: https://community.frame.work/t/kernel-6-8-rc-system-freezes-after-resuming-from-suspend-reproducers-wanted/45381


Fixes: 2b3a7f06 ("platform/x86/amd/pmf: Change return type of amd_pmf_set_dram_addr()")
Signed-off-by: default avatarMario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20240217005216.113408-1-mario.limonciello@amd.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 11e298f3

drivers/platform/x86/amd/pmf/core.c

+0 −2
Original line number Diff line number Diff line
@@ -299,8 +299,6 @@ static int amd_pmf_suspend_handler(struct device *dev) 
	if (pdev->smart_pc_enabled)

		cancel_delayed_work_sync(&pdev->pb_work);



	kfree(pdev->buf);



	return 0;

}