Commit b37cafac authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Petr Mladek
Browse files

ceph: Use no_printk() helper 



When printk-indexing is enabled, each printk() invocation emits a
pi_entry structure.  This is even true when the call is protected by an
always-false check: while the actual code to print the message is
optimized out by the compiler, the pi_entry structure is still emitted.

Fix this by replacing "if (0) printk(...)" constructs by calls to the
no_printk() helper.

This reduces the size of an arm64 kernel with CONFIG_PRINTK_INDEX=y and
CONFIG_CEPH_FS=y by ca. 4 KiB.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarXiubo Li <xiubli@redhat.com>
Reviewed-by: default avatarChris Down <chris@chrisdown.name>
Reviewed-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/a21767eccb823435a7f18cdf115d7d572b4e945d.1709127473.git.geert+renesas@glider.be


Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
parent 0381e588

include/linux/ceph/ceph_debug.h

+7 −11
Original line number Diff line number Diff line
@@ -27,17 +27,13 @@ 
		 ##__VA_ARGS__)

# else

/* faux printk call just to see any compiler warnings. */

#  define dout(fmt, ...)	do {				\

		if (0)						\

			printk(KERN_DEBUG fmt, ##__VA_ARGS__);	\

	} while (0)

#  define doutc(client, fmt, ...)	do {			\

		if (0)						\

			printk(KERN_DEBUG "[%pU %llu] " fmt,	\

#  define dout(fmt, ...)					\

		no_printk(KERN_DEBUG fmt, ##__VA_ARGS__)

#  define doutc(client, fmt, ...)				\

		no_printk(KERN_DEBUG "[%pU %llu] " fmt,		\

			  &client->fsid,			\

			  client->monc.auth->global_id,		\

			##__VA_ARGS__);				\

		} while (0)

			  ##__VA_ARGS__)

# endif



#else