Commit b4885bd5 authored by Alexandra Diupina's avatar Alexandra Diupina Committed by Steve French
Browse files

cifs: avoid NULL pointer dereference in dbg call 



cifs_server_dbg() implies server to be non-NULL so
move call under condition to avoid NULL pointer dereference.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: e79b0332 ("cifs: ignore cached share root handle closing errors")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarAlexandra Diupina <adiupina@astralinux.ru>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent f089ee00

fs/smb/client/smb2misc.c

+5 −4
Original line number Diff line number Diff line
@@ -816,11 +816,12 @@ smb2_handle_cancelled_close(struct cifs_tcon *tcon, __u64 persistent_fid, 
		WARN_ONCE(tcon->tc_count < 0, "tcon refcount is negative");

		spin_unlock(&cifs_tcp_ses_lock);



		if (tcon->ses)

		if (tcon->ses) {

			server = tcon->ses->server;



		cifs_server_dbg(FYI, "tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",

			cifs_server_dbg(FYI,

					"tid=0x%x: tcon is closing, skipping async close retry of fid %llu %llu\n",

					tcon->tid, persistent_fid, volatile_fid);

		}



		return 0;

	}