Commit f089ee00 authored by Ivan Abramov's avatar Ivan Abramov Committed by Steve French
Browse files

smb: client: Remove redundant check in smb2_is_path_accessible() 



There is an unnecessary NULL check of cifs_sb in smb2_is_path_accessible(),
since cifs_sb is dereferenced multiple times prior to it.

It seems that there is no need to introduce any NULL checks of cifs_sb,
since arguments of smb2_is_path_accessible() are assumed to be non-NULL.

Therefore, this redundant check can be removed.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: default avatarIvan Abramov <i.abramov@mt-integration.ru>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 9fb2e20e

fs/smb/client/smb2ops.c

+1 −1
Original line number Diff line number Diff line
@@ -969,7 +969,7 @@ smb2_is_path_accessible(const unsigned int xid, struct cifs_tcon *tcon, 
			if (islink)

				rc = -EREMOTE;

		}

		if (rc == -EREMOTE && IS_ENABLED(CONFIG_CIFS_DFS_UPCALL) && cifs_sb &&

		if (rc == -EREMOTE && IS_ENABLED(CONFIG_CIFS_DFS_UPCALL) &&

		    (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_NO_DFS))

			rc = -EOPNOTSUPP;

		goto out;