Commit b6d7a953 authored by Maxime Ripard's avatar Maxime Ripard Committed by Dave Stevenson
Browse files

drm/vc4: hvs: More logging for dlist generation 



DLIST generation can get pretty tricky and there's not a lot of debug in
the driver to help. Let's add a few more to track the generated DLIST
size.

Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240621152055.4180873-10-dave.stevenson@raspberrypi.com


Signed-off-by: default avatarDave Stevenson <dave.stevenson@raspberrypi.com>
parent 6ecfe7c2

drivers/gpu/drm/vc4/vc4_hvs.c

+12 −2
Original line number Diff line number Diff line
@@ -456,11 +456,21 @@ int vc4_hvs_atomic_check(struct drm_crtc *crtc, struct drm_atomic_state *state) 
	if (hweight32(crtc_state->connector_mask) > 1)

		return -EINVAL;



	drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state)

		dlist_count += vc4_plane_dlist_size(plane_state);

	drm_atomic_crtc_state_for_each_plane_state(plane, plane_state, crtc_state) {

		u32 plane_dlist_count = vc4_plane_dlist_size(plane_state);



		drm_dbg_driver(dev, "[CRTC:%d:%s] Found [PLANE:%d:%s] with DLIST size: %u\n",

			       crtc->base.id, crtc->name,

			       plane->base.id, plane->name,

			       plane_dlist_count);



		dlist_count += plane_dlist_count;

	}



	dlist_count++; /* Account for SCALER_CTL0_END. */



	drm_dbg_driver(dev, "[CRTC:%d:%s] Allocating DLIST block with size: %u\n",

		       crtc->base.id, crtc->name, dlist_count);

	spin_lock_irqsave(&vc4->hvs->mm_lock, flags);

	ret = drm_mm_insert_node(&vc4->hvs->dlist_mm, &vc4_state->mm,

				 dlist_count);