Commit b7d450d9 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: max31335: use regmap_update_bits_check 



Simplify the IRQ handler by using regmap_update_bits_check.

Reviewed-by: default avatarAntoniu Miclaus <antoniu.miclaus@analog.com>
Link: https://lore.kernel.org/r/20240115232215.273374-2-alexandre.belloni@bootlin.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 590b1d19

drivers/rtc/rtc-max31335.c

+5 −7
Original line number Diff line number Diff line
@@ -348,18 +348,16 @@ static int max31335_alarm_irq_enable(struct device *dev, unsigned int enabled) 
static irqreturn_t max31335_handle_irq(int irq, void *dev_id)

{

	struct max31335_data *max31335 = dev_id;

	int ret, status;

	bool status;

	int ret;



	ret = regmap_read(max31335->regmap, MAX31335_STATUS1, &status);

	ret = regmap_update_bits_check(max31335->regmap, MAX31335_STATUS1,

				       MAX31335_STATUS1_A1F, 0, &status);

	if (ret)

		return IRQ_HANDLED;



	if (FIELD_GET(MAX31335_STATUS1_A1F, status)) {

		regmap_update_bits(max31335->regmap, MAX31335_STATUS1,

				   MAX31335_STATUS1_A1F, 0);



	if (status)

		rtc_update_irq(max31335->rtc, 1, RTC_AF | RTC_IRQF);

	}



	return IRQ_HANDLED;

}