Commit b9b8301d authored by Eric Dumazet's avatar Eric Dumazet Committed by Jakub Kicinski
Browse files

net: netdevsim: fix nsim_pp_hold_write() 



nsim_pp_hold_write() has two problems:

1) It may return with rtnl held, as found by syzbot.

2) Its return value does not propagate an error if any.

Fixes: 1580cbcb ("net: netdevsim: add some fake page pool use")
Reported-by: default avatarsyzbot <syzkaller@googlegroups.com>
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20241216083703.1859921-1-edumazet@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7ed2d915

drivers/net/netdevsim/netdev.c

+2 −2
Original line number Diff line number Diff line
@@ -635,10 +635,10 @@ nsim_pp_hold_write(struct file *file, const char __user *data, 
		page_pool_put_full_page(ns->page->pp, ns->page, false);

		ns->page = NULL;

	}

	rtnl_unlock();



exit:

	return count;

	rtnl_unlock();

	return ret;

}



static const struct file_operations nsim_pp_hold_fops = {