Unverified Commit bc8ab440 authored by Maxime Ripard's avatar Maxime Ripard
Browse files

drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_cleanup_done() 



drm_atomic_helper_wait_for_dependencies() is the final part of a commit
and signals it completion. It takes the drm_atomic_state being committed
as a parameter.

However, that parameter name is called (and documented) as old_state,
which is pretty confusing. Let's rename that variable as state.

Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-25-e71598f49c8f@kernel.org


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 6280e96f

drivers/gpu/drm/drm_atomic_helper.c

+7 −7
Original line number Diff line number Diff line
@@ -2562,23 +2562,23 @@ EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done); 


/**

 * drm_atomic_helper_commit_cleanup_done - signal completion of commit

 * @old_state: atomic state object with old state structures

 * @state: atomic state object being committed

 *

 * This signals completion of the atomic update @old_state, including any

 * This signals completion of the atomic update @state, including any

 * cleanup work. If used, it must be called right before calling

 * drm_atomic_state_put().

 *

 * This is part of the atomic helper support for nonblocking commits, see

 * drm_atomic_helper_setup_commit() for an overview.

 */

void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state)

void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *state)

{

	struct drm_crtc *crtc;

	struct drm_crtc_state *old_crtc_state;

	struct drm_crtc_commit *commit;

	int i;



	for_each_old_crtc_in_state(old_state, crtc, old_crtc_state, i) {

	for_each_old_crtc_in_state(state, crtc, old_crtc_state, i) {

		commit = old_crtc_state->commit;

		if (WARN_ON(!commit))

			continue;
@@ -2591,9 +2591,9 @@ void drm_atomic_helper_commit_cleanup_done(struct drm_atomic_state *old_state) 
		spin_unlock(&crtc->commit_lock);

	}



	if (old_state->fake_commit) {

		complete_all(&old_state->fake_commit->cleanup_done);

		WARN_ON(!try_wait_for_completion(&old_state->fake_commit->hw_done));

	if (state->fake_commit) {

		complete_all(&state->fake_commit->cleanup_done);

		WARN_ON(!try_wait_for_completion(&state->fake_commit->hw_done));

	}

}

EXPORT_SYMBOL(drm_atomic_helper_commit_cleanup_done);