Commit bd225b95 authored by Honggyu Kim's avatar Honggyu Kim Committed by Andrew Morton
Browse files

mm/damon: fix divide by zero in damon_get_intervals_score() 

The current implementation allows having zero size regions with no special
reasons, but damon_get_intervals_score() gets crashed by divide by zero
when the region size is zero.

  [   29.403950] Oops: divide error: 0000 [#1] SMP NOPTI

This patch fixes the bug, but does not disallow zero size regions to keep
the backward compatibility since disallowing zero size regions might be a
breaking change for some users.

In addition, the same crash can happen when intervals_goal.access_bp is
zero so this should be fixed in stable trees as well.

Link: https://lkml.kernel.org/r/20250702000205.1921-5-honggyu.kim@sk.com


Fixes: f04b0fed ("mm/damon/core: implement intervals auto-tuning")
Signed-off-by: default avatarHonggyu Kim <honggyu.kim@sk.com>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent ddba1b6c

mm/damon/core.c

+1 −0
Original line number Diff line number Diff line
@@ -1449,6 +1449,7 @@ static unsigned long damon_get_intervals_score(struct damon_ctx *c) 
		}

	}

	target_access_events = max_access_events * goal_bp / 10000;

	target_access_events = target_access_events ? : 1;

	return access_events * 10000 / target_access_events;

}