Commit be1cc96d authored by Michael Klein's avatar Michael Klein Committed by Paolo Abeni
Browse files

net: phy: realtek: use __set_bit() in rtl8211f_led_hw_control_get() 



rtl8211f_led_hw_control_get() does not need atomic bit operations,
replace set_bit() by __set_bit().

Signed-off-by: default avatarMichael Klein <michael@fossekall.de>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250504172916.243185-6-michael@fossekall.de


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 8c4d0172

drivers/net/phy/realtek/realtek_main.c

+5 −5
Original line number Diff line number Diff line
@@ -659,17 +659,17 @@ static int rtl8211f_led_hw_control_get(struct phy_device *phydev, u8 index, 
	val &= RTL8211F_LEDCR_MASK;



	if (val & RTL8211F_LEDCR_LINK_10)

		set_bit(TRIGGER_NETDEV_LINK_10, rules);

		__set_bit(TRIGGER_NETDEV_LINK_10, rules);



	if (val & RTL8211F_LEDCR_LINK_100)

		set_bit(TRIGGER_NETDEV_LINK_100, rules);

		__set_bit(TRIGGER_NETDEV_LINK_100, rules);



	if (val & RTL8211F_LEDCR_LINK_1000)

		set_bit(TRIGGER_NETDEV_LINK_1000, rules);

		__set_bit(TRIGGER_NETDEV_LINK_1000, rules);



	if (val & RTL8211F_LEDCR_ACT_TXRX) {

		set_bit(TRIGGER_NETDEV_RX, rules);

		set_bit(TRIGGER_NETDEV_TX, rules);

		__set_bit(TRIGGER_NETDEV_RX, rules);

		__set_bit(TRIGGER_NETDEV_TX, rules);

	}



	return 0;