Commit bef1eef6 authored by Felix Gu's avatar Felix Gu Committed by Alexandre Belloni
Browse files

i3c: master: dw-i3c: Fix missing reset assertion in remove() callback 



The reset line acquired during probe is currently left deasserted when
the driver is unbound.

Switch to devm_reset_control_get_optional_exclusive_deasserted() to
ensure the reset is automatically re-asserted by the devres core when
the driver is removed.

Fixes: 62fe9d06 ("i3c: dw: Add power management support")
Reviewed-by: default avatarPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Link: https://patch.msgid.link/20260320-dw-i3c-v3-1-477040c2e3f5@gmail.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent e7a71862

drivers/i3c/master/dw-i3c-master.c

+3 −8
Original line number Diff line number Diff line
@@ -1606,13 +1606,11 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, 
	if (IS_ERR(master->pclk))

		return PTR_ERR(master->pclk);



	master->core_rst = devm_reset_control_get_optional_exclusive(&pdev->dev,

	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,

										"core_rst");

	if (IS_ERR(master->core_rst))

		return PTR_ERR(master->core_rst);



	reset_control_deassert(master->core_rst);



	spin_lock_init(&master->xferqueue.lock);

	INIT_LIST_HEAD(&master->xferqueue.list);
@@ -1624,7 +1622,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, 
			       dw_i3c_master_irq_handler, 0,

			       dev_name(&pdev->dev), master);

	if (ret)

		goto err_assert_rst;

		return ret;



	platform_set_drvdata(pdev, master);
@@ -1673,9 +1671,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, 
	pm_runtime_set_suspended(&pdev->dev);

	pm_runtime_dont_use_autosuspend(&pdev->dev);



err_assert_rst:

	reset_control_assert(master->core_rst);



	return ret;

}

EXPORT_SYMBOL_GPL(dw_i3c_common_probe);