Commit bf16bca6 authored by Shay Drory's avatar Shay Drory Committed by Jakub Kicinski
Browse files

net/mlx5: lag: Check for LAG device before creating debugfs 



__mlx5_lag_dev_add_mdev() may return 0 (success) even when an error
occurs that is handled gracefully. Consequently, the initialization
flow proceeds to call mlx5_ldev_add_debugfs() even when there is no
valid LAG context.

mlx5_ldev_add_debugfs() blindly created the debugfs directory and
attributes. This exposed interfaces (like the members file) that rely on
a valid ldev pointer, leading to potential NULL pointer dereferences if
accessed when ldev is NULL.

Add a check to verify that mlx5_lag_dev(dev) returns a valid pointer
before attempting to create the debugfs entries.

Fixes: 7f46a0b7 ("net/mlx5: Lag, add debugfs to query hardware lag state")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260330194015.53585-2-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f0f367a4

drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.c

+3 −0
Original line number Diff line number Diff line
@@ -160,8 +160,11 @@ DEFINE_SHOW_ATTRIBUTE(members); 


void mlx5_ldev_add_debugfs(struct mlx5_core_dev *dev)

{

	struct mlx5_lag *ldev = mlx5_lag_dev(dev);

	struct dentry *dbg;



	if (!ldev)

		return;

	dbg = debugfs_create_dir("lag", mlx5_debugfs_get_dev_root(dev));

	dev->priv.dbg.lag_debugfs = dbg;