Commit c2e793da authored by Rob Herring (Arm)'s avatar Rob Herring (Arm) Committed by Will Deacon
Browse files

perf: apple_m1: Don't disable counter in m1_pmu_enable_event() 



Currently m1_pmu_enable_event() starts by disabling the event counter
it has been asked to enable. This should not be necessary as the
counter (and the PMU as a whole) should not be active when
m1_pmu_enable_event() is called.

Cc: Marc Zyngier <maz@kernel.org>
Signed-off-by: default avatarRob Herring (Arm) <robh@kernel.org>
Reviewed-by: default avatarAnshuman Khandual <anshuman.khandual@arm.com>
Tested-by: default avatarJames Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250218-arm-brbe-v19-v20-6-4e9922fc2e8e@kernel.org


Signed-off-by: default avatarWill Deacon <will@kernel.org>
parent 7bf1001e

drivers/perf/apple_m1_cpu_pmu.c

+0 −4
Original line number Diff line number Diff line
@@ -396,10 +396,6 @@ static void m1_pmu_enable_event(struct perf_event *event) 
	user = event->hw.config_base & M1_PMU_CFG_COUNT_USER;

	kernel = event->hw.config_base & M1_PMU_CFG_COUNT_KERNEL;



	m1_pmu_disable_counter_interrupt(event->hw.idx);

	m1_pmu_disable_counter(event->hw.idx);

	isb();



	m1_pmu_configure_counter(event->hw.idx, evt, user, kernel);

	m1_pmu_enable_counter(event->hw.idx);

	m1_pmu_enable_counter_interrupt(event->hw.idx);