Commit c34a14bc authored by Venkata Ramana Nayana's avatar Venkata Ramana Nayana Committed by Matt Roper
Browse files

drm/xe/irq: Handle msix vector0 interrupt 



Current gu2host handler registered as MSI-X vector 0 and as per bspec for
a msix vector 0 interrupt, the driver must check the legacy registers
190008(TILE_INT_REG), 190060h (GT INTR Identity Reg 0) and other registers
mentioned in "Interrupt Service Routine Pseudocode" otherwise it will block
the next interrupts. To overcome this issue replacing guc2host handler
with legacy xe_irq_handler.

Fixes: da889070 ("drm/xe/irq: Separate MSI and MSI-X flows")
Bspec: 62357
Signed-off-by: default avatarVenkata Ramana Nayana <venkata.ramana.nayana@intel.com>
Reviewed-by: default avatarBalasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Link: https://patch.msgid.link/20251107083141.2080189-1-venkata.ramana.nayana@intel.com


Signed-off-by: default avatarMatt Roper <matthew.d.roper@intel.com>
parent 78ff838a

drivers/gpu/drm/xe/xe_irq.c

+1 −17
Original line number Diff line number Diff line
@@ -897,22 +897,6 @@ static int xe_irq_msix_init(struct xe_device *xe) 
	return 0;

}



static irqreturn_t guc2host_irq_handler(int irq, void *arg)

{

	struct xe_device *xe = arg;

	struct xe_tile *tile;

	u8 id;



	if (!atomic_read(&xe->irq.enabled))

		return IRQ_NONE;



	for_each_tile(tile, xe, id)

		xe_guc_irq_handler(&tile->primary_gt->uc.guc,

				   GUC_INTR_GUC2HOST);



	return IRQ_HANDLED;

}



static irqreturn_t xe_irq_msix_default_hwe_handler(int irq, void *arg)

{

	unsigned int tile_id, gt_id;
@@ -1029,7 +1013,7 @@ int xe_irq_msix_request_irqs(struct xe_device *xe) 
	u16 msix;



	msix = GUC2HOST_MSIX;

	err = xe_irq_msix_request_irq(xe, guc2host_irq_handler, xe,

	err = xe_irq_msix_request_irq(xe, xe_irq_handler(xe), xe,

				      DRIVER_NAME "-guc2host", false, &msix);

	if (err)

		return err;