Commit ca8dc595 authored by Dan Carpenter's avatar Dan Carpenter Committed by Hans Verkuil
Browse files

media: synopsys: hdmirx: Fix signedness bug in hdmirx_parse_dt() 



The num_clks is set this way:

	hdmirx_dev->num_clks = devm_clk_bulk_get_all(dev, &hdmirx_dev->clks);
        if (hdmirx_dev->num_clks < 1)
                return -ENODEV;

The devm_clk_bulk_get_all() function returns negative error codes so the
hdmirx_dev->num_cks variable needs to be signed for the error handling to
work.

Fixes: 7b59b132 ("media: platform: synopsys: Add support for HDMI input driver")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarDmitry Osipenko <dmitry.osipenko@collabora.com>
Signed-off-by: default avatarHans Verkuil <hverkuil@xs4all.nl>
parent fae8cab4

drivers/media/platform/synopsys/hdmirx/snps_hdmirx.c

+1 −1
Original line number Diff line number Diff line
@@ -151,7 +151,7 @@ struct snps_hdmirx_dev { 
	bool hpd_trigger_level_high;

	bool tmds_clk_ratio;

	bool plugged;

	u32 num_clks;

	int num_clks;

	u32 edid_blocks_written;

	u32 cur_fmt_fourcc;

	u32 color_depth;