Commit d54e34c5 authored by Miquel Raynal's avatar Miquel Raynal
Browse files

mtd: spinand: Use more specific naming for the write enable/disable op 



SPI operations have been initially described through macros implicitly
implying the use of a single SPI SDR bus. Macros for supporting dual and
quad I/O transfers have been added on top, generally inspired by vendor
naming, followed by DTR operations. Soon we might see octal
and even octal DTR operations as well (including the opcode byte).

Let's clarify what the macro really means by describing the expected bus
topology in the write enable/disable macro names.

Reviewed-by: default avatarTudor Ambarus <tudor.ambarus@linaro.org>
[Miquel: Fixed conflicts with -next by updating esmt and micron drivers]
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
parent b15d9713

drivers/mtd/nand/spi/core.c

+1 −1
Original line number Diff line number Diff line
@@ -362,7 +362,7 @@ static void spinand_ondie_ecc_save_status(struct nand_device *nand, u8 status) 


static int spinand_write_enable_op(struct spinand_device *spinand)

{

	struct spi_mem_op op = SPINAND_WR_EN_DIS_OP(true);

	struct spi_mem_op op = SPINAND_WR_EN_DIS_1S_0_0_OP(true);



	return spi_mem_exec_op(spinand->spimem, &op);

}

drivers/mtd/nand/spi/esmt.c

+1 −1
Original line number Diff line number Diff line
@@ -137,7 +137,7 @@ static int f50l1g41lb_user_otp_info(struct spinand_device *spinand, size_t len, 
static int f50l1g41lb_otp_lock(struct spinand_device *spinand, loff_t from,

			       size_t len)

{

	struct spi_mem_op write_op = SPINAND_WR_EN_DIS_OP(true);

	struct spi_mem_op write_op = SPINAND_WR_EN_DIS_1S_0_0_OP(true);

	struct spi_mem_op exec_op = SPINAND_PROG_EXEC_OP(0);

	u8 status;

	int ret;

drivers/mtd/nand/spi/micron.c

+1 −1
Original line number Diff line number Diff line
@@ -251,7 +251,7 @@ static int mt29f2g01abagd_user_otp_info(struct spinand_device *spinand, 
static int mt29f2g01abagd_otp_lock(struct spinand_device *spinand, loff_t from,

				   size_t len)

{

	struct spi_mem_op write_op = SPINAND_WR_EN_DIS_OP(true);

	struct spi_mem_op write_op = SPINAND_WR_EN_DIS_1S_0_0_OP(true);

	struct spi_mem_op exec_op = SPINAND_PROG_EXEC_OP(0);

	u8 status;

	int ret;

include/linux/mtd/spinand.h

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ 
		   SPI_MEM_OP_NO_DUMMY,					\

		   SPI_MEM_OP_NO_DATA)



#define SPINAND_WR_EN_DIS_OP(enable)					\

#define SPINAND_WR_EN_DIS_1S_0_0_OP(enable)					\

	SPI_MEM_OP(SPI_MEM_OP_CMD((enable) ? 0x06 : 0x04, 1),		\

		   SPI_MEM_OP_NO_ADDR,					\

		   SPI_MEM_OP_NO_DUMMY,					\