Commit d5ab616e authored by Andy Shevchenko's avatar Andy Shevchenko
Browse files

gpiolib: acpi: Remove index parameter from acpi_gpio_property_lookup() 



In all cases the supplied index is the same as the passed one in
the struct acpi_gpio_lookup. Remove index parameter and reuse one
from the struct acpi_gpio_lookup instead.

add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-14 (-14)
Function                                     old     new   delta
acpi_get_gpiod_by_index                      462     456      -6
acpi_gpio_property_lookup                    425     417      -8
Total: Before=15375, After=15361, chg -0.09%

Acked-by: default avatarMika Westerberg <westeri@kernel.org>
Link: https://lore.kernel.org/r/20250403160034.2680485-3-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 2c6c34e0

drivers/gpio/gpiolib-acpi.c

+6 −7
Original line number Diff line number Diff line
@@ -830,17 +830,17 @@ static int acpi_gpio_resource_lookup(struct acpi_gpio_lookup *lookup, 
	return 0;

}



static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode,

				     const char *propname, int index,

static int acpi_gpio_property_lookup(struct fwnode_handle *fwnode, const char *propname,

				     struct acpi_gpio_lookup *lookup)

{

	struct fwnode_reference_args args;

	unsigned int index = lookup->index;

	unsigned int quirks = 0;

	int ret;



	memset(&args, 0, sizeof(args));

	ret = __acpi_node_get_property_reference(fwnode, propname, index, 3,

						 &args);



	ret = __acpi_node_get_property_reference(fwnode, propname, index, 3, &args);

	if (ret) {

		struct acpi_device *adev;
@@ -905,8 +905,7 @@ static struct gpio_desc *acpi_get_gpiod_by_index(struct acpi_device *adev, 
	if (propname) {

		dev_dbg(&adev->dev, "GPIO: looking up %s\n", propname);



		ret = acpi_gpio_property_lookup(acpi_fwnode_handle(adev),

						propname, index, &lookup);

		ret = acpi_gpio_property_lookup(acpi_fwnode_handle(adev), propname, &lookup);

		if (ret)

			return ERR_PTR(ret);
@@ -955,7 +954,7 @@ static struct gpio_desc *acpi_get_gpiod_from_data(struct fwnode_handle *fwnode, 
	memset(&lookup, 0, sizeof(lookup));

	lookup.index = index;



	ret = acpi_gpio_property_lookup(fwnode, propname, index, &lookup);

	ret = acpi_gpio_property_lookup(fwnode, propname, &lookup);

	if (ret)

		return ERR_PTR(ret);