Commit d64d0287 authored by Javier Carrasco's avatar Javier Carrasco Committed by Bartosz Golaszewski
Browse files

gpio: sim: switch to device_for_each_child_node_scoped() 



Switch to device_for_each_child_node_scoped() to simplify the code by
removing the need for a call to fwnode_handle_put() in the error path.

This also prevents possible memory leaks if new error paths are added
without the required call to fwnode_handle_put().

Signed-off-by: default avatarJavier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240928-gpio_device_for_each_child_node_scoped-v1-2-c20eff315f4f@gmail.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 0a53be8e

drivers/gpio/gpio-sim.c

+2 −5
Original line number Diff line number Diff line
@@ -520,16 +520,13 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev) 
static int gpio_sim_probe(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct fwnode_handle *swnode;

	int ret;



	device_for_each_child_node(dev, swnode) {

	device_for_each_child_node_scoped(dev, swnode) {

		ret = gpio_sim_add_bank(swnode, dev);

		if (ret) {

			fwnode_handle_put(swnode);

		if (ret)

			return ret;

	}

	}



	return 0;

}