Commit d7a54d02 authored Jul 09, 2025 by Miri Korenblit Committed by Johannes Berg Jul 10, 2025

wifi: mac80211: always initialize sdata::key_list

This is currently not initialized for a virtual monitor, leading to a
NULL pointer dereference when - for example - iterating over all the
keys of all the vifs.

Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250709233400.8dcefe578497.I4c90a00ae3256520e063199d7f6f2580d5451acf@changeid

Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent a0669173

net/mac80211/iface.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1150,6 +1150,8 @@ static void ieee80211_sdata_init(struct ieee80211_local *local,
		{
		sdata->local = local;

		INIT_LIST_HEAD(&sdata->key_list);

		/*
		* Initialize the default link, so we can use link_id 0 for non-MLD,
		* and that continues to work for non-MLD-aware drivers that use just
		@@ -2210,8 +2212,6 @@ int ieee80211_if_add(struct ieee80211_local local, const char name,

		ieee80211_init_frag_cache(&sdata->frags);

		INIT_LIST_HEAD(&sdata->key_list);

		wiphy_delayed_work_init(&sdata->dec_tailroom_needed_wk,
		ieee80211_delayed_tailroom_dec);