Commit dec2d609 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev/clps711x-fb: Initialize fb_ops with fbdev macros 



Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary helpers in Kconfig.

The driver previously selected drawing ops for system memory
although it operates on I/O memory. Fixed now.

Fbdev drivers sometimes rely on the callbacks being NULL for a
default I/O-memory-based implementation to be invoked; hence
requiring the I/O helpers to be built in any case. Setting all
callbacks in all drivers explicitly will allow to make the I/O
helpers optional. This benefits systems that do not use these
functions.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231127131655.4020-22-tzimmermann@suse.de
parent bff13b8f

drivers/video/fbdev/Kconfig

+1 −3
Original line number Diff line number Diff line
@@ -146,10 +146,8 @@ config FB_ACORN 
config FB_CLPS711X

	tristate "CLPS711X LCD support"

	depends on FB && (ARCH_CLPS711X || COMPILE_TEST)

	select FB_IOMEM_HELPERS

	select FB_MODE_HELPERS

	select FB_SYS_FILLRECT

	select FB_SYS_COPYAREA

	select FB_SYS_IMAGEBLIT

	select LCD_CLASS_DEVICE

	select VIDEOMODE_HELPERS

	help

drivers/video/fbdev/clps711x-fb.c

+1 −3
Original line number Diff line number Diff line
@@ -155,13 +155,11 @@ static int clps711x_fb_blank(int blank, struct fb_info *info) 


static const struct fb_ops clps711x_fb_ops = {

	.owner		= THIS_MODULE,

	FB_DEFAULT_IOMEM_OPS,

	.fb_setcolreg	= clps711x_fb_setcolreg,

	.fb_check_var	= clps711x_fb_check_var,

	.fb_set_par	= clps711x_fb_set_par,

	.fb_blank	= clps711x_fb_blank,

	.fb_fillrect	= sys_fillrect,

	.fb_copyarea	= sys_copyarea,

	.fb_imageblit	= sys_imageblit,

};



static int clps711x_lcd_check_fb(struct lcd_device *lcddev, struct fb_info *fi)