Commit e07dea3d authored by Wentao Liang's avatar Wentao Liang Committed by Vinod Koul
Browse files

phy: rockchip: inno-usb2: Fix a double free bug in rockchip_usb2phy_probe() 



The for_each_available_child_of_node() calls of_node_put() to
release child_np in each success loop. After breaking from the
loop with the child_np has been released, the code will jump to
the put_child label and will call the of_node_put() again if the
devm_request_threaded_irq() fails. These cause a double free bug.

Fix by returning directly to avoid the duplicate of_node_put().

Fixes: ed2b5a8e ("phy: phy-rockchip-inno-usb2: support muxed interrupts")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarWentao Liang <vulab@iscas.ac.cn>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260109154626.2452034-1-vulab@iscas.ac.cn


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent fb211160

drivers/phy/rockchip/phy-rockchip-inno-usb2.c

+1 −1
Original line number Diff line number Diff line
@@ -1495,7 +1495,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) 
						rphy);

		if (ret) {

			dev_err_probe(rphy->dev, ret, "failed to request usb2phy irq handle\n");

			goto put_child;

			return ret;

		}

	}