Commit e72da82d authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge tag 'drm-fixes-2024-12-14' of https://gitlab.freedesktop.org/drm/kernel 

Pull drm fixes from Dave Airlie:
 "This is the weekly fixes pull for drm. Just has i915, xe and amdgpu
  changes in it. Nothing too major in here:

  i915:
   - Don't use indexed register writes needlessly [dsb]
   - Stop using non-posted DSB writes for legacy LUT [color]
   - Fix NULL pointer dereference in capture_engine
   - Fix memory leak by correcting cache object name in error handler

  xe:
   - Fix a KUNIT test error message (Mirsad Todorovac)
   - Fix an invalidation fence PM ref leak (Daniele)
   - Fix a register pool UAF (Lucas)

  amdgpu:
   - ISP hw init fix
   - SR-IOV fixes
   - Fix contiguous VRAM mapping for UVD on older GPUs
   - Fix some regressions due to drm scheduler changes
   - Workload profile fixes
   - Cleaner shader fix

  amdkfd:
   - Fix DMA map direction for migration
   - Fix a potential null pointer dereference
   - Cacheline size fixes
   - Runtime PM fix"

* tag 'drm-fixes-2024-12-14' of https://gitlab.freedesktop.org/drm/kernel:
  drm/xe/reg_sr: Remove register pool
  drm/xe: Call invalidation_fence_fini for PT inval fences in error state
  drm/xe: fix the ERR_PTR() returned on failure to allocate tiny pt
  drm/amdkfd: pause autosuspend when creating pdd
  drm/amdgpu: fix when the cleaner shader is emitted
  drm/amdgpu: Fix ISP HW init issue
  drm/amdkfd: hard-code MALL cacheline size for gfx11, gfx12
  drm/amdkfd: hard-code cacheline size for gfx11
  drm/amdkfd: Dereference null return value
  drm/i915: Fix memory leak by correcting cache object name in error handler
  drm/i915: Fix NULL pointer dereference in capture_engine
  drm/i915/color: Stop using non-posted DSB writes for legacy LUT
  drm/i915/dsb: Don't use indexed register writes needlessly
  drm/amdkfd: Correct the migration DMA map direction
  drm/amd/pm: Set SMU v13.0.7 default workload type
  drm/amd/pm: Initialize power profile mode
  amdgpu/uvd: get ring reference from rq scheduler
  drm/amdgpu: fix UVD contiguous CS mapping problem
  drm/amdgpu: use sjt mec fw on gfx943 for sriov
  Revert "drm/amdgpu: Fix ISP hw init issue"
parents 974acf99 d172ea67

drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c

+11 −6
Original line number Diff line number Diff line
@@ -1801,13 +1801,18 @@ int amdgpu_cs_find_mapping(struct amdgpu_cs_parser *parser, 
	if (dma_resv_locking_ctx((*bo)->tbo.base.resv) != &parser->exec.ticket)

		return -EINVAL;



	/* Make sure VRAM is allocated contigiously */

	(*bo)->flags |= AMDGPU_GEM_CREATE_VRAM_CONTIGUOUS;

	if ((*bo)->tbo.resource->mem_type == TTM_PL_VRAM &&

	    !((*bo)->tbo.resource->placement & TTM_PL_FLAG_CONTIGUOUS)) {



		amdgpu_bo_placement_from_domain(*bo, (*bo)->allowed_domains);

		for (i = 0; i < (*bo)->placement.num_placement; i++)

			(*bo)->placements[i].flags |= TTM_PL_FLAG_CONTIGUOUS;

		r = ttm_bo_validate(&(*bo)->tbo, &(*bo)->placement, &ctx);

		if (r)

			return r;

	}



	return amdgpu_ttm_alloc_gart(&(*bo)->tbo);

}

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

+1 −1
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ const char *amdgpu_asic_name[] = { 
	"LAST",

};



#define AMDGPU_IP_BLK_MASK_ALL GENMASK(AMDGPU_MAX_IP_NUM, 0)

#define AMDGPU_IP_BLK_MASK_ALL GENMASK(AMD_IP_BLOCK_TYPE_NUM  - 1, 0)

/*

 * Default init level where all blocks are expected to be initialized. This is

 * the level of initialization expected by default and also after a full reset

drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c

+2 −0
Original line number Diff line number Diff line
@@ -551,6 +551,8 @@ static void amdgpu_uvd_force_into_uvd_segment(struct amdgpu_bo *abo) 
	for (i = 0; i < abo->placement.num_placement; ++i) {

		abo->placements[i].fpfn = 0 >> PAGE_SHIFT;

		abo->placements[i].lpfn = (256 * 1024 * 1024) >> PAGE_SHIFT;

		if (abo->placements[i].mem_type == TTM_PL_VRAM)

			abo->placements[i].flags |= TTM_PL_FLAG_CONTIGUOUS;

	}

}

drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

+7 −6
Original line number Diff line number Diff line
@@ -674,12 +674,8 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, 
	pasid_mapping_needed &= adev->gmc.gmc_funcs->emit_pasid_mapping &&

		ring->funcs->emit_wreg;



	if (adev->gfx.enable_cleaner_shader &&

	    ring->funcs->emit_cleaner_shader &&

	    job->enforce_isolation)

		ring->funcs->emit_cleaner_shader(ring);



	if (!vm_flush_needed && !gds_switch_needed && !need_pipe_sync)

	if (!vm_flush_needed && !gds_switch_needed && !need_pipe_sync &&

	    !(job->enforce_isolation && !job->vmid))

		return 0;



	amdgpu_ring_ib_begin(ring);
@@ -690,6 +686,11 @@ int amdgpu_vm_flush(struct amdgpu_ring *ring, struct amdgpu_job *job, 
	if (need_pipe_sync)

		amdgpu_ring_emit_pipeline_sync(ring);



	if (adev->gfx.enable_cleaner_shader &&

	    ring->funcs->emit_cleaner_shader &&

	    job->enforce_isolation)

		ring->funcs->emit_cleaner_shader(ring);



	if (vm_flush_needed) {

		trace_amdgpu_vm_flush(ring, job->vmid, job->vm_pd_addr);

		amdgpu_ring_emit_vm_flush(ring, job->vmid, job->vm_pd_addr);

drivers/gpu/drm/amd/amdgpu/gfx_v9_4_3.c

+8 −2
Original line number Diff line number Diff line
@@ -45,6 +45,8 @@ MODULE_FIRMWARE("amdgpu/gc_9_4_3_mec.bin"); 
MODULE_FIRMWARE("amdgpu/gc_9_4_4_mec.bin");

MODULE_FIRMWARE("amdgpu/gc_9_4_3_rlc.bin");

MODULE_FIRMWARE("amdgpu/gc_9_4_4_rlc.bin");

MODULE_FIRMWARE("amdgpu/gc_9_4_3_sjt_mec.bin");

MODULE_FIRMWARE("amdgpu/gc_9_4_4_sjt_mec.bin");



#define GFX9_MEC_HPD_SIZE 4096

#define RLCG_UCODE_LOADING_START_ADDRESS 0x00002000L
@@ -574,6 +576,10 @@ static int gfx_v9_4_3_init_cp_compute_microcode(struct amdgpu_device *adev, 
{

	int err;



	if (amdgpu_sriov_vf(adev))

		err = amdgpu_ucode_request(adev, &adev->gfx.mec_fw,

				"amdgpu/%s_sjt_mec.bin", chip_name);

	else

		err = amdgpu_ucode_request(adev, &adev->gfx.mec_fw,

				"amdgpu/%s_mec.bin", chip_name);

	if (err)