Commit e8c73eb7 authored by Edward Adam Davis's avatar Edward Adam Davis Committed by Steve French
Browse files

cifs: client: fix memory leak in smb3_fs_context_parse_param 



The user calls fsconfig twice, but when the program exits, free() only
frees ctx->source for the second fsconfig, not the first.
Regarding fc->source, there is no code in the fs context related to its
memory reclamation.

To fix this memory leak, release the source memory corresponding to ctx
or fc before each parsing.

syzbot reported:
BUG: memory leak
unreferenced object 0xffff888128afa360 (size 96):
  backtrace (crc 79c9c7ba):
    kstrdup+0x3c/0x80 mm/util.c:84
    smb3_fs_context_parse_param+0x229b/0x36c0 fs/smb/client/fs_context.c:1444

BUG: memory leak
unreferenced object 0xffff888112c7d900 (size 96):
  backtrace (crc 79c9c7ba):
    smb3_fs_context_fullpath+0x70/0x1b0 fs/smb/client/fs_context.c:629
    smb3_fs_context_parse_param+0x2266/0x36c0 fs/smb/client/fs_context.c:1438

Reported-by: default avatar <syzbot+72afd4c236e6bc3f4bac@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=72afd4c236e6bc3f4bac


Cc: stable@vger.kernel.org
Reviewed-by: default avatarPaulo Alcantara (Red Hat) <pc@manguebit.org>
Signed-off-by: default avatarEdward Adam Davis <eadavis@qq.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent 79280191

fs/smb/client/fs_context.c

+2 −0
Original line number Diff line number Diff line
@@ -1435,12 +1435,14 @@ static int smb3_fs_context_parse_param(struct fs_context *fc, 
			cifs_errorf(fc, "Unknown error parsing devname\n");

			goto cifs_parse_mount_err;

		}

		kfree(ctx->source);

		ctx->source = smb3_fs_context_fullpath(ctx, '/');

		if (IS_ERR(ctx->source)) {

			ctx->source = NULL;

			cifs_errorf(fc, "OOM when copying UNC string\n");

			goto cifs_parse_mount_err;

		}

		kfree(fc->source);

		fc->source = kstrdup(ctx->source, GFP_KERNEL);

		if (fc->source == NULL) {

			cifs_errorf(fc, "OOM when copying UNC string\n");