Commit ed661216 authored by Yiqi Sun's avatar Yiqi Sun Committed by Steve French
Browse files

smb: fix invalid username check in smb3_fs_context_parse_param() 



Since the maximum return value of strnlen(..., CIFS_MAX_USERNAME_LEN)
is CIFS_MAX_USERNAME_LEN, length check in smb3_fs_context_parse_param()
is always FALSE and invalid.

Fix the comparison in if statement.

Signed-off-by: default avatarYiqi Sun <sunyiqixm@gmail.com>
Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
parent e8c73eb7

fs/smb/client/fs_context.c

+1 −1
Original line number Diff line number Diff line
@@ -1470,7 +1470,7 @@ static int smb3_fs_context_parse_param(struct fs_context *fc, 
			break;

		}



		if (strnlen(param->string, CIFS_MAX_USERNAME_LEN) >

		if (strnlen(param->string, CIFS_MAX_USERNAME_LEN) ==

		    CIFS_MAX_USERNAME_LEN) {

			pr_warn("username too long\n");

			goto cifs_parse_mount_err;