Commit f26fde36 authored by Yang Li's avatar Yang Li Committed by Vinod Koul
Browse files

phy: ti: j721e-wiz: add missing call to of_node_put() 



In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1614244674-66556-1-git-send-email-yang.lee@linux.alibaba.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 982313c3

drivers/phy/ti/phy-j721e-wiz.c

+1 −0
Original line number Diff line number Diff line
@@ -1104,6 +1104,7 @@ static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz) 


		ret = of_property_read_u32(subnode, "reg", &reg);

		if (ret) {

			of_node_put(subnode);

			dev_err(dev,

				"%s: Reading \"reg\" from \"%s\" failed: %d\n",

				__func__, subnode->name, ret);