Commit f2d90e07 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

usb: typec: stusb160x: fix return value check in stusb160x_probe() 



In case of error, the function device_get_named_child_node() returns
NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: da0cb631 ("usb: typec: add support for STUSB160x Type-C controller family")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarAmelie Delaunay <amelie.delaunay@foss.st.com>
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Link: https://lore.kernel.org/r/20210308094839.3586773-1-weiyongjun1@huawei.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 604c7589

drivers/usb/typec/stusb160x.c

+2 −2
Original line number Diff line number Diff line
@@ -682,8 +682,8 @@ static int stusb160x_probe(struct i2c_client *client) 
	}



	fwnode = device_get_named_child_node(chip->dev, "connector");

	if (IS_ERR(fwnode))

		return PTR_ERR(fwnode);

	if (!fwnode)

		return -ENODEV;



	/*

	 * When both VDD and VSYS power supplies are present, the low power