Commit f421692b authored by Karan Tilak Kumar's avatar Karan Tilak Kumar Committed by Martin K. Petersen
Browse files

scsi: fnic: Remove unnecessary spinlock locking and unlocking 



Remove unnecessary locking and unlocking of spinlock in
fdls_schedule_oxid_free_retry_work().  This will shorten the time in the
critical section.

Suggested-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Fixes: a63e78eb ("scsi: fnic: Add support for fabric based solicited requests and responses")
Reviewed-by: default avatarSesidhar Baddela <sebaddel@cisco.com>
Reviewed-by: default avatarArulprabhu Ponnusamy <arulponn@cisco.com>
Reviewed-by: default avatarGian Carlo Boffa <gcboffa@cisco.com>
Reviewed-by: default avatarArun Easi <aeasi@cisco.com>
Tested-by: default avatarKaran Tilak Kumar <kartilak@cisco.com>
Signed-off-by: default avatarKaran Tilak Kumar <kartilak@cisco.com>
Link: https://lore.kernel.org/r/20250301013712.3115-2-kartilak@cisco.com


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7f5dce6e

drivers/scsi/fnic/fdls_disc.c

+7 −17
Original line number Diff line number Diff line
@@ -311,38 +311,28 @@ void fdls_schedule_oxid_free_retry_work(struct work_struct *work) 
	unsigned long flags;

	int idx;



	spin_lock_irqsave(&fnic->fnic_lock, flags);



	for_each_set_bit(idx, oxid_pool->pending_schedule_free, FNIC_OXID_POOL_SZ) {



		FNIC_FCS_DBG(KERN_INFO, fnic->host, fnic->fnic_num,

			"Schedule oxid free. oxid idx: %d\n", idx);



		spin_unlock_irqrestore(&fnic->fnic_lock, flags);

		reclaim_entry = kzalloc(sizeof(*reclaim_entry), GFP_KERNEL);

		spin_lock_irqsave(&fnic->fnic_lock, flags);



		if (!reclaim_entry) {

			schedule_delayed_work(&oxid_pool->schedule_oxid_free_retry,

				msecs_to_jiffies(SCHEDULE_OXID_FREE_RETRY_TIME));

			spin_unlock_irqrestore(&fnic->fnic_lock, flags);

			return;

		}



		if (test_and_clear_bit(idx, oxid_pool->pending_schedule_free)) {

		clear_bit(idx, oxid_pool->pending_schedule_free);

		reclaim_entry->oxid_idx = idx;

		reclaim_entry->expires = round_jiffies(jiffies + delay_j);

		spin_lock_irqsave(&fnic->fnic_lock, flags);

		list_add_tail(&reclaim_entry->links, &oxid_pool->oxid_reclaim_list);

		spin_unlock_irqrestore(&fnic->fnic_lock, flags);

		schedule_delayed_work(&oxid_pool->oxid_reclaim_work, delay_j);

		} else {

			/* unlikely scenario, free the allocated memory and continue */

			kfree(reclaim_entry);

	}

}



	spin_unlock_irqrestore(&fnic->fnic_lock, flags);

}



static bool fdls_is_oxid_fabric_req(uint16_t oxid)

{

	int oxid_frame_type = FNIC_FRAME_TYPE(oxid);