Commit f6259ba7 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

tools: ynl: check for membership with 'not in' 

It is better to use 'not in' instead of 'not {element} in {collection}'
according to Ruff.

This is linked to Ruff error E713 [1]:

  Testing membership with {element} not in {collection} is more readable.

Link: https://docs.astral.sh/ruff/rules/not-in-test/

 [1]
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarDonald Hunter <donald.hunter@gmail.com>
Reviewed-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Link: https://patch.msgid.link/20250909-net-next-ynl-ruff-v1-8-238c2bccdd99@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 10d32b0d

tools/net/ynl/pyynl/ynl_gen_c.py

+1 −1
Original line number Diff line number Diff line
@@ -638,7 +638,7 @@ class TypeBitfield32(Type): 
        return '.type = YNL_PT_BITFIELD32, '



    def _attr_policy(self, policy):

        if not 'enum' in self.attr:

        if 'enum' not in self.attr:

            raise Exception('Enum required for bitfield32 attr')

        enum = self.family.consts[self.attr['enum']]

        mask = enum.get_mask(as_flags=True)