Commit f775276e authored by Heiko Carstens's avatar Heiko Carstens Committed by Vasily Gorbik
Browse files

s390/xor: Fix xor_xc_2() inline assembly constraints 



The inline assembly constraints for xor_xc_2() are incorrect. "bytes",
"p1", and "p2" are input operands, while all three of them are modified
within the inline assembly. Given that the function consists only of this
inline assembly it seems unlikely that this may cause any problems, however
fix this in any case.

Fixes: 2cfc5f9c ("s390/xor: optimized xor routing using the XC instruction")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Reviewed-by: default avatarVasily Gorbik <gor@linux.ibm.com>
Link: https://lore.kernel.org/r/20260302133500.1560531-2-hca@linux.ibm.com


Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
parent 5f258053

arch/s390/lib/xor.c

+2 −2
Original line number Diff line number Diff line
@@ -28,8 +28,8 @@ static void xor_xc_2(unsigned long bytes, unsigned long * __restrict p1, 
		"	j	3f\n"

		"2:	xc	0(1,%1),0(%2)\n"

		"3:"

		: : "d" (bytes), "a" (p1), "a" (p2)

		: "0", "cc", "memory");

		: "+d" (bytes), "+a" (p1), "+a" (p2)

		: : "0", "cc", "memory");

}



static void xor_xc_3(unsigned long bytes, unsigned long * __restrict p1,