Commit f8b12dfb authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: pm8001: Fix payload initialization in pm80xx_encrypt_update() 

All fields of the kek_mgmt_req structure have the type __le32. So make sure
to use cpu_to_le32() to initialize them. This suppresses the sparse
warning:

warning: incorrect type in assignment (different base types)
   expected restricted __le32 [addressable] [assigned] [usertype] new_curidx_ksop
   got int

Link: https://lore.kernel.org/r/20220220031810.738362-10-damien.lemoal@opensource.wdc.com


Fixes: f5860992 ("[SCSI] pm80xx: Added SPCv/ve specific hardware functionalities and relevant changes in common files")
Reviewed-by: default avatarJack Wang <jinpu.wang@ionos.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent ca374f5d

drivers/scsi/pm8001/pm80xx_hwi.c

+4 −3
Original line number Diff line number Diff line
@@ -1405,12 +1405,13 @@ static int pm80xx_encrypt_update(struct pm8001_hba_info *pm8001_ha) 
	/* Currently only one key is used. New KEK index is 1.

	 * Current KEK index is 1. Store KEK to NVRAM is 1.

	 */

	payload.new_curidx_ksop = ((1 << 24) | (1 << 16) | (1 << 8) |

					KEK_MGMT_SUBOP_KEYCARDUPDATE);

	payload.new_curidx_ksop =

		cpu_to_le32(((1 << 24) | (1 << 16) | (1 << 8) |

			     KEK_MGMT_SUBOP_KEYCARDUPDATE));



	pm8001_dbg(pm8001_ha, DEV,

		   "Saving Encryption info to flash. payload 0x%x\n",

		   payload.new_curidx_ksop);

		   le32_to_cpu(payload.new_curidx_ksop));



	rc = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &payload,

			sizeof(payload), 0);