Commit fff4a5d5 authored by Lino Sanfilippo's avatar Lino Sanfilippo Committed by Greg Kroah-Hartman
Browse files

serial: ar933x: Remove unneeded static structure 



In case that no RTS GPIO is available do not use a dedicated nullified
serial_rs485 struct to disable RS485 support, but simply delete the
SER_RS485_ENABLED flag in the ports rs485_supported struct.
This make the structure superfluous and it can be removed.

Signed-off-by: default avatarLino Sanfilippo <l.sanfilippo@kunbus.com>
Link: https://lore.kernel.org/r/20240407002709.16224-5-l.sanfilippo@kunbus.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 384fa864

drivers/tty/serial/ar933x_uart.c

+1 −2
Original line number Diff line number Diff line
@@ -692,7 +692,6 @@ static struct uart_driver ar933x_uart_driver = { 
	.cons		= NULL, /* filled in runtime */

};



static const struct serial_rs485 ar933x_no_rs485 = {};

static const struct serial_rs485 ar933x_rs485_supported = {

	.flags = SER_RS485_ENABLED | SER_RS485_RTS_ON_SEND | SER_RS485_RTS_AFTER_SEND,

};
@@ -788,7 +787,7 @@ static int ar933x_uart_probe(struct platform_device *pdev) 
	up->rts_gpiod = mctrl_gpio_to_gpiod(up->gpios, UART_GPIO_RTS);



	if (!up->rts_gpiod) {

		port->rs485_supported = ar933x_no_rs485;

		port->rs485_supported.flags &= ~SER_RS485_ENABLED;

		if (port->rs485.flags & SER_RS485_ENABLED) {

			dev_err(&pdev->dev, "lacking rts-gpio, disabling RS485\n");

			port->rs485.flags &= ~SER_RS485_ENABLED;