mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/
synced 2026-04-03 23:37:40 -04:00
printk: nbcon: Check for device_{lock,unlock} callbacks
These callbacks are necessary to synchronize ->write_thread callback against other operations using the same device. Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com> Reviewed-by: John Ogness <john.ogness@linutronix.de> Link: https://patch.msgid.link/20251208-nbcon-device-cb-fix-v2-1-36be8d195123@suse.com Signed-off-by: Petr Mladek <pmladek@suse.com>
This commit is contained in:
committed by
Petr Mladek
parent
4d38b88fd1
commit
bdfcca65e7
@@ -1760,9 +1760,12 @@ bool nbcon_alloc(struct console *con)
|
||||
/* Synchronize the kthread start. */
|
||||
lockdep_assert_console_list_lock_held();
|
||||
|
||||
/* The write_thread() callback is mandatory. */
|
||||
if (WARN_ON(!con->write_thread))
|
||||
/* Check for mandatory nbcon callbacks. */
|
||||
if (WARN_ON(!con->write_thread ||
|
||||
!con->device_lock ||
|
||||
!con->device_unlock)) {
|
||||
return false;
|
||||
}
|
||||
|
||||
rcuwait_init(&con->rcuwait);
|
||||
init_irq_work(&con->irq_work, nbcon_irq_work);
|
||||
|
||||
Reference in New Issue
Block a user