Commit 04d63da4 authored by Waiman Long's avatar Waiman Long Committed by Tejun Heo
Browse files

cgroup/cpuset: Fix incorrect top_cpuset flags 



Commit 8996f93f ("cgroup/cpuset: Statically initialize more
members of top_cpuset") uses an incorrect "<" relational operator for
the CS_SCHED_LOAD_BALANCE bit when initializing the top_cpuset. This
results in load_balancing turned off by default in the top cpuset which
is bad for performance.

Fix this by using the BIT() helper macro to set the desired top_cpuset
flags and avoid similar mistake from being made in the future.

Fixes: 8996f93f ("cgroup/cpuset: Statically initialize more members of top_cpuset")
Signed-off-by: default avatarWaiman Long <longman@redhat.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent e8784765

kernel/cgroup/cpuset.c

+2 −2
Original line number Diff line number Diff line
@@ -368,8 +368,8 @@ static inline void notify_partition_change(struct cpuset *cs, int old_prs) 
}



static struct cpuset top_cpuset = {

	.flags = ((1 << CS_ONLINE) | (1 << CS_CPU_EXCLUSIVE) |

		  (1 << CS_MEM_EXCLUSIVE) | (1 < CS_SCHED_LOAD_BALANCE)),

	.flags = BIT(CS_ONLINE) | BIT(CS_CPU_EXCLUSIVE) |

		 BIT(CS_MEM_EXCLUSIVE) | BIT(CS_SCHED_LOAD_BALANCE),

	.partition_root_state = PRS_ROOT,

	.relax_domain_level = -1,

	.remote_sibling = LIST_HEAD_INIT(top_cpuset.remote_sibling),