Commit 0dc83ad8 authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Stephen Boyd
Browse files

clk: samsung: Don't register clkdev lookup for the fixed rate clocks 



Commit 4d11c62ca8d7 ("clkdev: report over-sized strings when creating
clkdev entries") revealed that clock lookup is registered for all fixed
clocks. The mentioned commit added a check if the registered name is not
too long. This fails for some clocks registered for Exynos542x SoCs family.
This lookup is a left-over from early common clock framework days, not
really needed nowadays, so remove it to avoid further issues.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Tested-by: default avatarSam Protsenko <semen.protsenko@linaro.org>
Link: https://lore.kernel.org/r/20240510065901.535124-1-m.szyprowski@samsung.com


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent ce689628

drivers/clk/samsung/clk.c

+1 −10
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx, 
		unsigned int nr_clk)

{

	struct clk_hw *clk_hw;

	unsigned int idx, ret;

	unsigned int idx;



	for (idx = 0; idx < nr_clk; idx++, list++) {

		clk_hw = clk_hw_register_fixed_rate(ctx->dev, list->name,
@@ -151,15 +151,6 @@ void __init samsung_clk_register_fixed_rate(struct samsung_clk_provider *ctx, 
		}



		samsung_clk_add_lookup(ctx, clk_hw, list->id);



		/*

		 * Unconditionally add a clock lookup for the fixed rate clocks.

		 * There are not many of these on any of Samsung platforms.

		 */

		ret = clk_hw_register_clkdev(clk_hw, list->name, NULL);

		if (ret)

			pr_err("%s: failed to register clock lookup for %s",

				__func__, list->name);

	}

}