Unverified Commit 12849745 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki Committed by Ilpo Järvinen
Browse files

platform/x86: toshiba_haps: Fix memory leaks in add/remove routines 



toshiba_haps_add() leaks the haps object allocated by it if it returns
an error after allocating that object successfully.

toshiba_haps_remove() does not free the object pointed to by
toshiba_haps before clearing that pointer, so it becomes unreachable
allocated memory.

Address these memory leaks by using devm_kzalloc() for allocating
the memory in question.

Fixes: 23d0ba0c ("platform/x86: Toshiba HDD Active Protection Sensor")
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 43b0b7ef

drivers/platform/x86/toshiba_haps.c

+1 −1
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ static int toshiba_haps_add(struct acpi_device *acpi_dev) 


	pr_info("Toshiba HDD Active Protection Sensor device\n");



	haps = kzalloc(sizeof(struct toshiba_haps_dev), GFP_KERNEL);

	haps = devm_kzalloc(&acpi_dev->dev, sizeof(*haps), GFP_KERNEL);

	if (!haps)

		return -ENOMEM;