Commit 1b6f292c authored by Prasanna Kumar T S M's avatar Prasanna Kumar T S M Committed by Borislav Petkov (AMD)
Browse files

EDAC/versalnet: Fix memory leak in remove and probe error paths 



The mcdi object allocated using kzalloc() in the setup_mcdi() is not freed in
the remove path or in probe's error handling path leading to a memory leak.
Fix it by freeing the allocated memory.

Fixes: d5fe2fec ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: default avatarPrasanna Kumar T S M <ptsm@linux.microsoft.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20260322131139.1684716-1-ptsm@linux.microsoft.com
parent fbe230a9

drivers/edac/versalnet_edac.c

+2 −0
Original line number Diff line number Diff line
@@ -937,6 +937,7 @@ static int mc_probe(struct platform_device *pdev) 


err_init:

	cdx_mcdi_finish(priv->mcdi);

	kfree(priv->mcdi);



err_unreg:

	unregister_rpmsg_driver(&amd_rpmsg_driver);
@@ -958,6 +959,7 @@ static void mc_remove(struct platform_device *pdev) 
	remove_versalnet(priv);

	rproc_shutdown(priv->mcdi->r5_rproc);

	cdx_mcdi_finish(priv->mcdi);

	kfree(priv->mcdi);

}



static const struct of_device_id amd_edac_match[] = {