Commit 22cedc60 authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Jakub Kicinski
Browse files

net: dsa: mt753x: remove setting of tx_lpi parameters 



dsa_user_get_eee() calls the DSA switch get_mac_eee() method followed
by phylink_ethtool_get_eee(), which goes on to call
phy_ethtool_get_eee(). This overwrites all members of the passed
ethtool_keee, which means anything written by the DSA switch
get_mac_eee() method will be discarded.

Remove setting any members in mt753x_get_mac_eee().

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarChester A. Unal <chester.a.unal@arinc9.com>
Link: https://patch.msgid.link/E1tUlku-007Uyc-RP@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0945a7b4

drivers/net/dsa/mt7530.c

+0 −6
Original line number Diff line number Diff line
@@ -3088,12 +3088,6 @@ mt753x_setup(struct dsa_switch *ds) 
static int mt753x_get_mac_eee(struct dsa_switch *ds, int port,

			      struct ethtool_keee *e)

{

	struct mt7530_priv *priv = ds->priv;

	u32 eeecr = mt7530_read(priv, MT753X_PMEEECR_P(port));



	e->tx_lpi_enabled = !(eeecr & LPI_MODE_EN);

	e->tx_lpi_timer = LPI_THRESH_GET(eeecr);



	return 0;

}