Commit 2b8c43e7 authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf trace beauty: Add shellcheck to scripts 



Add shell check to scripts generating perf trace lookup tables. Fix
quoting issue in arch_errno_names.sh.

Reviewed-by: default avatarJames Clark <james.clark@arm.com>
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Link: https://lore.kernel.org/r/20240409023216.2342032-5-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 61ff60aa

tools/perf/trace/beauty/Build

+14 −0
Original line number Diff line number Diff line
@@ -20,3 +20,17 @@ perf-y += statx.o 
perf-y += sync_file_range.o

perf-y += timespec.o

perf-y += tracepoints/



ifdef SHELLCHECK

  SHELL_TESTS := $(wildcard trace/beauty/*.sh)

  TEST_LOGS := $(SHELL_TESTS:trace/beauty/%=%.shellcheck_log)

else

  SHELL_TESTS :=

  TEST_LOGS :=

endif



$(OUTPUT)%.shellcheck_log: %

	$(call rule_mkdir)

	$(Q)$(call echo-cmd,test)shellcheck -s bash -a -S warning "$<" > $@ || (cat $@ && rm $@ && false)



perf-y += $(TEST_LOGS)

tools/perf/trace/beauty/arch_errno_names.sh

+5 −3
Original line number Diff line number Diff line
@@ -60,10 +60,12 @@ create_arch_errno_table_func() 
	printf 'arch_syscalls__strerrno_t *arch_syscalls__strerrno_function(const char *arch)\n'

	printf '{\n'

	for arch in $archlist; do

		printf '\tif (!strcmp(arch, "%s"))\n' $(arch_string "$arch")

		printf '\t\treturn errno_to_name__%s;\n' $(arch_string "$arch")

		arch_str=$(arch_string "$arch")

		printf '\tif (!strcmp(arch, "%s"))\n' "$arch_str"

		printf '\t\treturn errno_to_name__%s;\n' "$arch_str"

	done

	printf '\treturn errno_to_name__%s;\n' $(arch_string "$default")

	arch_str=$(arch_string "$default")

	printf '\treturn errno_to_name__%s;\n' "$arch_str"

	printf '}\n'

}