Commit 3c6abbe8 authored by Stefano Garzarella's avatar Stefano Garzarella Committed by Jakub Kicinski
Browse files

vsock/test: check also expected errno on sigpipe test 



In the sigpipe test, we expect send() to fail, but we do not check if
send() fails with the errno we expect (EPIPE).

Add this check and repeat the send() in case of EINTR as we do in other
tests.

Signed-off-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://patch.msgid.link/20250514141927.159456-4-sgarzare@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 135a8a4d

tools/testing/vsock/vsock_test.c

+10 −2
Original line number Diff line number Diff line
@@ -1075,7 +1075,7 @@ static void test_stream_check_sigpipe(int fd) 
	timeout_begin(TIMEOUT);

	while(1) {

		res = send(fd, "A", 1, 0);

		if (res == -1)

		if (res == -1 && errno != EINTR)

			break;



		/* Sleep a little before trying again to avoid flooding the
@@ -1087,6 +1087,10 @@ static void test_stream_check_sigpipe(int fd) 
	}

	timeout_end();



	if (errno != EPIPE) {

		fprintf(stderr, "unexpected send(2) errno %d\n", errno);

		exit(EXIT_FAILURE);

	}

	if (!have_sigpipe) {

		fprintf(stderr, "SIGPIPE expected\n");

		exit(EXIT_FAILURE);
@@ -1097,7 +1101,7 @@ static void test_stream_check_sigpipe(int fd) 
	timeout_begin(TIMEOUT);

	while(1) {

		res = send(fd, "A", 1, MSG_NOSIGNAL);

		if (res == -1)

		if (res == -1 && errno != EINTR)

			break;



		timeout_usleep(SEND_SLEEP_USEC);
@@ -1105,6 +1109,10 @@ static void test_stream_check_sigpipe(int fd) 
	}

	timeout_end();



	if (errno != EPIPE) {

		fprintf(stderr, "unexpected send(2) errno %d\n", errno);

		exit(EXIT_FAILURE);

	}

	if (have_sigpipe) {

		fprintf(stderr, "SIGPIPE not expected\n");

		exit(EXIT_FAILURE);